-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests fail in component
package; 修复ut报错
#528
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
kind/bug
kind/easy
Comments
seeflood
added
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
labels
May 3, 2022
Subtask of #529 |
seeflood
changed the title
Unit tests fail in
Unit tests fail in Jun 14, 2022
component
packagecomponent
package 修复ut报错
seeflood
changed the title
Unit tests fail in
Unit tests fail in Jun 15, 2022
component
package 修复ut报错component
package; 修复ut报错
这个问题可以让我跟进下吗? |
@leemos-xx Ok. Thanks! |
你好,这个问题在 #529 中似乎被标记为fixed,目前我在 |
@leemos-xx 我现在本地不报错,但是看了下代码、以及上面的报错信息,猜测是: anyway, 不管这个拦截的事情,ut其实不该依赖外部环境,或者说,这个ut 最好不要给 example.com发请求 A. mock掉发请求的部分,不发出真实请求 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
kind/bug
kind/easy
What happened:
Run unit tests under
component
package:Then you will get some errors:
The test cases have dependency on remote environment (and even need some token to run).
We should fix them by mocking all the remote environment.
The failed tests include:
- [ ] aws s3What you expected to happen:
Run unit tests locally with success
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
The text was updated successfully, but these errors were encountered: