Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: make check.lint should check different go modules 让make脚本检查不同的 go 模块 #598

Open
seeflood opened this issue May 23, 2022 · 2 comments · Fixed by #601
Open

ci: make check.lint should check different go modules 让make脚本检查不同的 go 模块 #598

seeflood opened this issue May 23, 2022 · 2 comments · Fixed by #601
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/ci priority/medium

Comments

@seeflood
Copy link
Member

seeflood commented May 23, 2022 •
edited
Loading

What would you like to be added:
Layotto have multiple go modules in one repo, including:

  • root module
  • components/
  • demo/
  • sdk/go-sdk/
  • spec

Currently our make check.lint script only check the root module.

We should improve our script to check different go modules automatically.

Why is this needed:
To make code contribution easier
@seeflood
Copy link
Member Author

similar issues:
golangci/golangci-lint-action#74
golangci/golangci-lint#828

@seeflood seeflood added good first issue Good for newcomers help wanted Extra attention is needed area/ci labels May 23, 2022
@seeflood seeflood mentioned this issue May 23, 2022
Merged
4 tasks
@seeflood seeflood self-assigned this May 23, 2022
@seeflood seeflood reopened this May 26, 2022
@seeflood
Copy link
Member Author

seeflood commented May 26, 2022 •
edited
Loading

Update: now the github workflow can check submodules. Fixed by #601
As for the next step, we should let the make check.lint script check all the submodules

@seeflood seeflood removed their assignment May 26, 2022
@seeflood seeflood mentioned this issue May 26, 2022
Closed
25 tasks
@seeflood seeflood changed the title ci: linter should check different go modules ci: make check.lint should check different go modules Jun 14, 2022
@seeflood seeflood changed the title ci: make check.lint should check different go modules ci: make check.lint should check different go modules 让make脚本检查不同的 go 模块 Jun 14, 2022
@Kelei0215 Kelei0215 mentioned this issue Jun 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/ci priority/medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: linter check submodules seeflood/layotto
1 participant
@seeflood