Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unstable ut; 修复不稳定的单测 #682

Closed
seeflood opened this issue Jun 29, 2022 · 2 comments · Fixed by #701
Closed

fix unstable ut; 修复不稳定的单测 #682

seeflood opened this issue Jun 29, 2022 · 2 comments · Fixed by #701
Assignees
Labels
area/test good first issue Good for newcomers help wanted Extra attention is needed kind/easy

Comments

@seeflood
Copy link
Member

seeflood commented Jun 29, 2022

What would you like to be added:
The UT in components/lock/zookeeper/zookeeper_lock_test.go is not stable. Sometimes some lines of components/lock/zookeeper/zookeeper_lock.go are not covered in the UT and will lead to decreased test coverage.
For example , codecov reports it in #678 (comment)
image

It's because some code runs in a seperated goroutine. At the end of the test, the goroutine has not been executed:
image

We should make the test coverage stable

Why is this needed:
No more codecov warning

@ZLBer
Copy link
Member

ZLBer commented Jul 6, 2022

@seeflood who make who fix 😅

@seeflood
Copy link
Member Author

seeflood commented Jul 6, 2022

image

This issue is one of the tasks in #654 and you can get some presents after fixing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test good first issue Good for newcomers help wanted Extra attention is needed kind/easy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants