Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when consuming more messages that exist in topic #273

Closed
vvargas90 opened this issue Feb 1, 2024 · 7 comments · Fixed by #287
Closed

Error when consuming more messages that exist in topic #273

vvargas90 opened this issue Feb 1, 2024 · 7 comments · Fixed by #287
Assignees
Labels
✨ Feature Request New feature or request

Comments

@vvargas90
Copy link

Steps to reproduce:

  • Create a Reader with offset 10
  • Last offset of the topic is 13
  • I want to consume 10 messages

Expected result
I just get 3 messages back, as are the ones that exist in the topic

Actual result
I get the 3 messages back but I have an error I can't even catch in k6:
image
It comes from here https://github.com/mostafa/xk6-kafka/blob/main/reader.go#L344 but I can't capture it as an XK6KafkaError.

@mostafa
Copy link
Owner

mostafa commented Feb 1, 2024

@vvargas90

This is the expected behavior based on the current design. Would be happy to see contributions.

@davidgomesdev
Copy link
Contributor

Why is that? It's not even possible to see what the error is @mostafa

@mostafa
Copy link
Owner

mostafa commented Apr 26, 2024

@davidgomesdev @vvargas90

Good question! I am trying to fix it. Will raise a PR soon and would be happy to have your feedback.

@mostafa
Copy link
Owner

mostafa commented Apr 26, 2024

@davidgomesdev @vvargas90 Can you test the changes?

@mostafa mostafa added the ✨ Feature Request New feature or request label Apr 26, 2024
@mostafa mostafa self-assigned this Apr 26, 2024
@mostafa mostafa moved this from Todo to Doing in xk6-kafka Apr 26, 2024
@github-project-automation github-project-automation bot moved this from Doing to Test in xk6-kafka Apr 29, 2024
@davidgomesdev
Copy link
Contributor

Hi @mostafa, I was referring to it lacking details, rather than not being catch-able, it now indeed is possible to catch the error, but I wanted to see more information regarding the error itself.

@mostafa
Copy link
Owner

mostafa commented Apr 29, 2024

@davidgomesdev I won't be able to decipher the error any more than you do. I made the kafka-go's error catch-able, so you can search the error in that library.

@davidgomesdev
Copy link
Contributor

This was what I meant @mostafa #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature Request New feature or request
Projects
Status: Release
Development

Successfully merging a pull request may close this issue.

3 participants