Skip to content

Commit

Permalink
Added android tests
Browse files Browse the repository at this point in the history
  • Loading branch information
tompahoward committed Nov 10, 2020
1 parent 4aca6b2 commit c507263
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
9 changes: 5 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@ This isomorphic library is compatible with Node.js 10.x, 12.x and 14.x, Chrome,
[![GitHub issues](https://img.shields.io/github/issues/mountain-pass/waychaser)](https://github.com/mountain-pass/waychaser/issues) [![GitHub pull requests](https://img.shields.io/github/issues-pr/mountain-pass/waychaser)](https://github.com/mountain-pass/waychaser/pulls)


| <img src="https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg" alt="Node.js" width="48px" height="48px" /><br/>Node.js | <img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/chrome/chrome_48x48.png" alt="Chrome" width="24px" height="24px" /><br/>Chrome | <img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/firefox/firefox_48x48.png" alt="Firefox" width="24px" height="24px" /><br/>Firefox | <img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/safari/safari_48x48.png" alt="Safari" width="24px" height="24px" /><br/>Safari | <img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/edge/edge_48x48.png" alt="Edge" width="24px" height="24px" /><br/>Edge | <img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/safari-ios/safari-ios_48x48.png" alt="iOS Safari" width="24px" height="24px" /><br/>iOS Safari | <img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/archive/internet-explorer_9-11/internet-explorer_9-11_48x48.png" alt="IE" width="24px" height="24px" /><br/>IE |
| --------- | --------- | --------- | --------- | --------- | --------- | --------- |
| 10.x, 12.x, 14.x | latest version | latest version| latest version| latest version | latest version | 11 |
| <img src="https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg" alt="Node.js" width="48px" height="48px" /><br/>Node.js | <img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/chrome/chrome_48x48.png" alt="Chrome" width="24px" height="24px" /><br/>Chrome | <img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/firefox/firefox_48x48.png" alt="Firefox" width="24px" height="24px" /><br/>Firefox | <img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/safari/safari_48x48.png" alt="Safari" width="24px" height="24px" /><br/>Safari | <img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/edge/edge_48x48.png" alt="Edge" width="24px" height="24px" /><br/>Edge | <img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/safari-ios/safari-ios_48x48.png" alt="iOS Safari" width="24px" height="24px" /><br/>iOS Safari | <img src="https://source.android.com/setup/images/Android_symbol_green_RGB.svg" alt="Android" width="24px" height="24px" /><br/>Android | <img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/archive/internet-explorer_9-11/internet-explorer_9-11_48x48.png" alt="IE" width="24px" height="24px" /><br/>IE |
| --------- | --------- | --------- | --------- | --------- | --------- | --------- | --------- |
| 10.x, 12.x, 14.x | latest version | latest version| latest version| latest version | latest version | latest version | 11 |




Expand Down Expand Up @@ -237,8 +238,8 @@ library.load(“https://api-addressr.mountain-pass.com.au”)
- [x] archive test results
- [x] have pull requests from fork run node-api and chrome local
- [x] iOS Safari testing
- [x] Andriod Chrome testing
- [ ] expand code-climate analysis
- [ ] Andriod Chrome testing
- [ ] create docs site
- [ ] integrate Code coverage and code quality reporting
- [ ] integrate API docs
Expand Down
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"test:browser-api:safari:local": "scripts/test-browser.sh",
"test:browser-api:safari:remote": "scripts/test-browser.sh",
"test:browser-api:iphone:remote": "scripts/test-browser.sh",
"test:browser-api:android:remote": "scripts/test-browser.sh",
"test:browser-api:edge:remote": "scripts/test-browser.sh",
"test:browser-api:ie:remote": "scripts/test-browser.sh",
"test:browser-api": "scripts/for-all-browsers.sh",
Expand All @@ -70,6 +71,7 @@
"cover:browser-api:safari:local": "scripts/cover.sh",
"cover:browser-api:safari:remote": "scripts/cover.sh",
"cover:browser-api:iphone:remote": "scripts/cover.sh",
"cover:browser-api:android:remote": "scripts/cover.sh",
"cover:browser-api:edge:remote": "scripts/cover.sh",
"cover:browser-api:ie:remote": "scripts/cover.sh",
"cover:browser-api": "scripts/for-all-browsers.sh",
Expand Down
3 changes: 2 additions & 1 deletion src/test/clients/waychaser-via-webdriver-remote.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ class WaychaserViaWebdriverRemote extends WaychaserViaWebdriver {
accessKey: process.env.BROWSERSTACK_ACCESS_KEY,
},
browserName: this.browser,
...(this.browser !== 'iphone' && { browserVersion: 'latest' }),
...(this.browser !== 'iphone' &&
this.browser !== 'android' && { browserVersion: 'latest' }),
};

this.driver = new webdriver.Builder()
Expand Down

0 comments on commit c507263

Please sign in to comment.