Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page Iterator in utilities #519

Closed
elyse-weiss opened this issue May 5, 2021 · 1 comment
Closed

Page Iterator in utilities #519

elyse-weiss opened this issue May 5, 2021 · 1 comment
Labels
enhancement Impact - something should be added to or changed about Parsons that isn't causing a current breakage parsons core Work type - changes to core Parsons infrastructure pieces (like the Parsons table or API connector)

Comments

@elyse-weiss
Copy link
Contributor

Given the number of endpoints that include page number, it may be helpful to add a Page Iterator to utilities.

Here's a helpful Slack thread for context: https://tmc-parsons.slack.com/archives/C018N5ZCB99/p1620164384066600
@elyse-weiss elyse-weiss added the enhancement Impact - something should be added to or changed about Parsons that isn't causing a current breakage label May 5, 2021
@SorenSpicknall SorenSpicknall added the parsons core Work type - changes to core Parsons infrastructure pieces (like the Parsons table or API connector) label Mar 17, 2022
@shaunagm
Copy link
Collaborator

Closing this in favor of #554 and #736 - I think we should create a page iterator utility and then expose it as a method in APIConnector class. This makes it easier for connectors based on APIConnector to use it, but also makes it importable for other connectors or use cases.

@shaunagm shaunagm mentioned this issue Feb 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Impact - something should be added to or changed about Parsons that isn't causing a current breakage parsons core Work type - changes to core Parsons infrastructure pieces (like the Parsons table or API connector)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shaunagm @SorenSpicknall @elyse-weiss