Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .hpp extension for headers #857

Open
tylerjw opened this issue Dec 1, 2021 · 4 comments
Open

Use .hpp extension for headers #857

tylerjw opened this issue Dec 1, 2021 · 4 comments

Comments

@tylerjw
Copy link
Member

tylerjw commented Dec 1, 2021

https://github.com/cpp-best-practices/cppbestpractices/blob/master/03-Style.md#use-hpp-and-cpp-for-your-file-extensions

@JorgePerC
Copy link

Hey, I would like to help, are there any specific instructions on how to do so?

@TSNoble
Copy link
Contributor

TSNoble commented Nov 16, 2024

I'd be interested in picking this up if it's not being worked on?

@TSNoble
Copy link
Contributor

TSNoble commented Nov 18, 2024

Should be finished with the following items:

  • Replace majority of internal headers with hpps (Enhancement/use hpp for headers #3113)
  • Replace c library imports with c++ equivalents
  • Replace ros.h imports with rclcpp imports
  • Replace ROS1 msg imports with ROS2 msg imports
  • Replace fmtlib imports with std::format
  • Replace non-ROS library imports with hpp imports where possible
  • Fix header install destination (Fix header install destination #3134)
  • Replace ikfast.h with ikfast.hpp (may be fixed by autogeneration of deprecated c-style headers)
  • Get GENERATE_EXPORT_HEADER() macro to export hpps
  • Linting to ensure that the standard is maintained (i.e. fail on detection of .h files)

Edit: Added the points below to the list. Will mark as outdated when I'm back on my work account

@rr-tom-noble

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants