-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Jest addon for source files #48
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 21
Lines 21 24 +3
=====================================
+ Hits 21 24 +3
Continue to review full report at Codecov.
|
aab3b58
to
d3ec7e3
Compare
'env': { | ||
'jest/globals': false, | ||
}, | ||
'files': [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if this key is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint complains with an error saying 'files'
is mandatory
addons/jest.js
Outdated
'excludedFiles': [ | ||
'**/__tests__/**/*.js', | ||
'**/?(.*)*@(spec|test).js', | ||
'test/**/*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include test
and tests
addons/jest.js
Outdated
'**/?(.*)*@(spec|test).js', | ||
'test/**/*', | ||
], | ||
'rules': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get the rules defined in rules/jest.js
and apply a map operation to deactivate them all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,33 @@ | |||
// `no-disabled-tests` - Disallow disabled tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change file name to non-test-file.js
@@ -0,0 +1,33 @@ | |||
// `no-disabled-tests` - Disallow disabled tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test
and tests
folder
test/.eslintrc.json
Outdated
@@ -1,8 +1,6 @@ | |||
{ | |||
"root": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this change
addons/jest.js
Outdated
'**/?(.*)*@(spec|test).js', | ||
'test/**/*', | ||
], | ||
'rules': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.eslintrc.json
Outdated
@@ -2,7 +2,8 @@ | |||
"root": true, | |||
"extends": [ | |||
"./es5.js", | |||
"./addons/node.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rever this change
b6f2eb9
to
18cc1fa
Compare
18cc1fa
to
5145754
Compare
5145754
to
f1a4334
Compare
Fixes #31