Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Jest addon for source files #48

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Disable Jest addon for source files #48

merged 1 commit into from
Mar 14, 2018

Conversation

acostalima
Copy link
Contributor

Fixes #31

@acostalima acostalima requested a review from satazor February 24, 2018 18:36
@codecov
Copy link

codecov bot commented Feb 24, 2018

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #48   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines          21     24    +3     
=====================================
+ Hits           21     24    +3
Impacted Files Coverage Δ
addons/jest.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60054d...f1a4334. Read the comment docs.

'env': {
'jest/globals': false,
},
'files': [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if this key is needed

Copy link
Contributor Author

@acostalima acostalima Mar 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint complains with an error saying 'files' is mandatory

addons/jest.js Outdated
'excludedFiles': [
'**/__tests__/**/*.js',
'**/?(.*)*@(spec|test).js',
'test/**/*',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include test and tests

addons/jest.js Outdated
'**/?(.*)*@(spec|test).js',
'test/**/*',
],
'rules': {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get the rules defined in rules/jest.js and apply a map operation to deactivate them all

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,33 @@
// `no-disabled-tests` - Disallow disabled tests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change file name to non-test-file.js

@@ -0,0 +1,33 @@
// `no-disabled-tests` - Disallow disabled tests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test and tests folder

@@ -1,8 +1,6 @@
{
"root": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change

addons/jest.js Outdated
'**/?(.*)*@(spec|test).js',
'test/**/*',
],
'rules': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.eslintrc.json Outdated
@@ -2,7 +2,8 @@
"root": true,
"extends": [
"./es5.js",
"./addons/node.js"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rever this change

@acostalima acostalima force-pushed the jest-test-dir branch 2 times, most recently from b6f2eb9 to 18cc1fa Compare March 14, 2018 00:16
@satazor satazor merged commit 08bf0c6 into master Mar 14, 2018
@satazor satazor deleted the jest-test-dir branch March 14, 2018 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants