Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Codemirror editor is very broken when editing recipes #524

Closed
mythmon opened this issue Oct 16, 2020 · 3 comments
Closed

Codemirror editor is very broken when editing recipes #524

mythmon opened this issue Oct 16, 2020 · 3 comments
Labels

Comments

@mythmon
Copy link
Contributor

mythmon commented Oct 16, 2020

This must have happened from some package update

image

@mythmon mythmon added the defect label Oct 16, 2020
@mythmon
Copy link
Contributor Author

mythmon commented Oct 16, 2020

git bisect points to ed5a460 / #449.

@mythmon
Copy link
Contributor Author

mythmon commented Oct 16, 2020

I found this issue: codemirror/codemirror5#5484

That isn't exactly our situation, but it makes me wonder if the code splitting (which means that module-globals are no longer shared between modules) is to blame here. I'm not sure how to go about fixing this. I think if we can't figure out how to make this compatible, we can go back to not lazy loading the pages for the web version.

This doesn't affect the extension version of NDT.

@mythmon
Copy link
Contributor Author

mythmon commented Oct 22, 2020

Fixed by #551.

@mythmon mythmon closed this as completed Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant