-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add Dockerfile to rebuild in container #1402
build: Add Dockerfile to rebuild in container #1402
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1402 +/- ##
==========================================
+ Coverage 74.67% 74.77% +0.09%
==========================================
Files 127 127
Lines 6168 6168
Branches 861 861
==========================================
+ Hits 4606 4612 +6
+ Misses 1379 1374 -5
+ Partials 183 182 -1
Continue to review full report at Codecov.
|
Dockerfile
Outdated
# WARNING: https://github.com/mozilla-iot/gateway-docker | ||
|
||
FROM debian:stable | ||
MAINTAINER Philippe Coval (p.coval@samsung.com) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This docker file is a conveinance tool for developers, for production deployment please consider this project: https://github.com/mozilla-iot/gateway-docker Also run-app.sh can be used to start gw, more changes to come later. Usage: docker-compose up Forwarded: WebThingsIO#1402 Change-Id: Ia082fdcb1b945645ff5c058760dbefed8843eea8 Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
5764a16
to
796c14e
Compare
@rzr What's the purpose of this since we already have a full production-ready Docker image? |
it can be used for testing local changes on a fresh env |
It would probably be useful to allow sharing in the |
Actually I prefer to not mix previously used contents, I prefer to start on blank container to make sure everything is reproducible on the current codebase, but I can submit a config sharing change in later commit. |
This docker file is a conveinance tool for developers,
for production deployment please consider this project:
https://github.com/mozilla-iot/gateway-docker
Also run-app.sh can be used to start gw,
more changes to come later.
Usage:
Change-Id: Ia082fdcb1b945645ff5c058760dbefed8843eea8
Signed-off-by: Philippe Coval philippe.coval@osg.samsung.com