Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor shared bits of the post_contact and put_contact fixtures #215

Open
jwhitlock opened this issue May 13, 2021 · 1 comment
Open

Refactor shared bits of the post_contact and put_contact fixtures #215

jwhitlock opened this issue May 13, 2021 · 1 comment
Labels
dev Enhancements to development environment

Comments

@jwhitlock
Copy link
Contributor

jwhitlock commented May 13, 2021 •
edited by data-sync-user
Loading

The post_contact and put_contact fixtures have similar functionality, but differ in the details. It should be possible to extract the two versions of _check_written and _add into a separate combined function, and use functools.partial to bind the sample data and return versions suitable for both fixtures.

┆Issue is synchronized with this Jira Task
@jwhitlock jwhitlock added the dev Enhancements to development environment label May 13, 2021
@jwhitlock jwhitlock mentioned this issue May 13, 2021
Merged
@leplatrem
Copy link
Contributor

leplatrem commented Sep 17, 2024 •
edited
Loading

This was done in #958

Not fully 😓

@leplatrem leplatrem reopened this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev Enhancements to development environment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwhitlock @leplatrem