Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically commit objects created by factories in tests #949

Closed
grahamalama opened this issue Jul 30, 2024 · 0 comments · Fixed by #951
Closed

Automatically commit objects created by factories in tests #949

grahamalama opened this issue Jul 30, 2024 · 0 comments · Fixed by #951

Comments

@grahamalama
Copy link
Contributor

#946 (review)

Since we dbsession.commit() everywhere where factories are used, wouldn't it simpler to do it in the factory function?

This would be nicer. factoryboy has an option to automatically commit objects on creation, though when I tried adding that change to #946, but I saw some errors pop up that made it warrant investigation in a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant