You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
In the above PR, we added exception handling for all the API places calls to prevent crashes on Errors.
However, in the case a catchable error happens in the retrieval of the bookmarks we return an empty string to the app, which is a smell. We should change those apis to return nullable strings, and have the consuming app handle the null value properly.
The APIs to change are the addItem and addFolder functions in that were modified in the PR mentioned above
This is a follow-up to #12300
In the above PR, we added exception handling for all the API places calls to prevent crashes on Errors.
However, in the case a catchable error happens in the retrieval of the bookmarks we return an empty string to the app, which is a smell. We should change those apis to return nullable strings, and have the consuming app handle the null value properly.
The APIs to change are the
addItem
andaddFolder
functions in that were modified in the PR mentioned above┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: