Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Return nullable strings from the apis that return the bookmark GUIDs #12413

Closed
tarikeshaq opened this issue Jun 29, 2022 · 1 comment
Closed

Comments

@tarikeshaq
Copy link
Contributor

tarikeshaq commented Jun 29, 2022

This is a follow-up to #12300

In the above PR, we added exception handling for all the API places calls to prevent crashes on Errors.

However, in the case a catchable error happens in the retrieval of the bookmarks we return an empty string to the app, which is a smell. We should change those apis to return nullable strings, and have the consuming app handle the null value properly.

The APIs to change are the addItem and addFolder functions in that were modified in the PR mentioned above

┆Issue is synchronized with this Jira Task

@csadilek
Copy link
Contributor

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1794914

Change performed by the Move to Bugzilla add-on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants