Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Expose "session history" in Session #1340

Closed
pocmo opened this issue Nov 13, 2018 · 8 comments · Fixed by #7024
Closed

Expose "session history" in Session #1340

pocmo opened this issue Nov 13, 2018 · 8 comments · Fixed by #7024
Assignees
Labels
<engine-gecko> Component: browser-engine-gecko <engine-system> Component: browser-engine-system (WebView) 🌟 feature New functionality and improvements 🐉 Fenix Feature needed for Fenix 🌐 reference browser Features, bugs, issues related to the reference browser implementation <session> Component: browser-session <sync-tabs> Components: concept-storage
Milestone

Comments

@pocmo
Copy link
Contributor

pocmo commented Nov 13, 2018

Reference browser user story: mozilla-mobile/reference-browser#69

To be able to render the "history" of a single Session we will need to expose this list in the Session itself.

Unclear is where this data should come from.

┆Issue is synchronized with this Jira Task

@pocmo pocmo added <session> Component: browser-session <engine-gecko> Component: browser-engine-gecko <engine-system> Component: browser-engine-system (WebView) 🌟 feature New functionality and improvements needs:gv To implement/fix this we need a new API in GeckoView labels Nov 13, 2018
@pocmo
Copy link
Contributor Author

pocmo commented Nov 13, 2018

May need a GeckoView API. Currently snorp says we could implement this on our own by using the HistoryDelegate. However I am a bit concerned that we will have issues keeping the GeckoSession history stack and our own list in sync.

@pocmo
Copy link
Contributor Author

pocmo commented Nov 22, 2018

@pocmo
Copy link
Contributor Author

pocmo commented Nov 29, 2018

After discussing this with the GV team the consensus is that GV will provide APIs for:

  • Getting the history list of a GeckoSession.
  • Getting the current index (in the list) the session is at
  • Navigating to a specific index (this is something we'd implement in a different issue)

@pocmo
Copy link
Contributor Author

pocmo commented Nov 29, 2018

@pocmo pocmo added 📺 Fire TV 🌐 reference browser Features, bugs, issues related to the reference browser implementation labels Nov 29, 2018
@pocmo pocmo mentioned this issue Jan 2, 2019
4 tasks
@pocmo pocmo mentioned this issue Jan 24, 2019
18 tasks
@pocmo pocmo added the 🐉 Fenix Feature needed for Fenix label Feb 1, 2019
@vesta0 vesta0 added the blocked Blocked pull requests and issues label Apr 2, 2019
@ghost ghost added the MaybeFenix? label Apr 3, 2019
@pocmo pocmo removed MaybeFenix? 🐉 Fenix Feature needed for Fenix labels Apr 8, 2019
@vesta0 vesta0 removed the blocked Blocked pull requests and issues label Apr 29, 2019
@bifleming
Copy link

@vesta0 this is still in the 'blocked' column on teh A/C sprint board... should it be moved? But is it post-MVP? we should take everything that is Post-MVP off of that board I think.

@vesta0 vesta0 added the P2 label May 8, 2019
@pocmo pocmo removed the needs:gv To implement/fix this we need a new API in GeckoView label Jul 11, 2019
@vesta0 vesta0 removed the P2 label Jul 16, 2019
@pocmo pocmo added 🐉 Fenix Feature needed for Fenix and removed Fenix-After-MVP labels Jul 26, 2019
@jonalmeida
Copy link
Contributor

jonalmeida commented Nov 7, 2019

This would be needed for supporting the tab history for sync tabs.

@jonalmeida
Copy link
Contributor

jonalmeida commented Nov 7, 2019

This seems mostly for "read" access to the history stack, but we would need a way to add to it.

It isn't blocking sync tabs, but would be eventually needed to land the final feature.

@jonalmeida jonalmeida added the <sync-tabs> Components: concept-storage label Nov 8, 2019
@jonalmeida jonalmeida linked a pull request May 19, 2020 that will close this issue
4 tasks
@bors bors bot closed this as completed in 3df24ee May 22, 2020
@pocmo pocmo added this to the 43.0.0 milestone May 27, 2020
@data-sync-user data-sync-user changed the title Expose "session history" in Session FNX-3564 ⁃ Expose "session history" in Session Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX-3564 ⁃ Expose "session history" in Session Expose "session history" in Session May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
<engine-gecko> Component: browser-engine-gecko <engine-system> Component: browser-engine-system (WebView) 🌟 feature New functionality and improvements 🐉 Fenix Feature needed for Fenix 🌐 reference browser Features, bugs, issues related to the reference browser implementation <session> Component: browser-session <sync-tabs> Components: concept-storage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants