Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Merge day! #4301

Merged
merged 3 commits into from
Sep 3, 2019
Merged

Merge day! #4301

merged 3 commits into from
Sep 3, 2019

Conversation

pocmo
Copy link
Contributor

@pocmo pocmo commented Sep 3, 2019

New GeckoView versions!

  • browser-engine-gecko-beta (69) -> browser-engine-gecko-release (69)
  • browser-engine-gecko-nightly (70) -> browser-engine-gecko-beta (70)
  • browser-engine-gecko-nightly -> 71

This time I took some notes. I'll turn this into a documentation and then next time someone else can try them and perform the merge day changes. :)

This also needs to be added to the changelog. But I'm heading out now for today. Will add that later.


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@pocmo pocmo added the 🕵️‍♀️ needs review PRs that need to be reviewed label Sep 3, 2019
@pocmo pocmo requested a review from a team as a code owner September 3, 2019 17:38
@rocketsroger
Copy link
Contributor

bors r=rocketsroger

bors bot pushed a commit that referenced this pull request Sep 3, 2019
4301: Merge day! r=rocketsroger a=pocmo

New GeckoView versions!

* browser-engine-gecko-beta (69) -> browser-engine-gecko-release (69)
* browser-engine-gecko-nightly (70) -> browser-engine-gecko-beta (70)
* browser-engine-gecko-nightly -> 71

This time I took some notes. I'll turn this into a documentation and then next time someone else can try them and perform the merge day changes. :)

This also needs to be added to the changelog. But I'm heading out now for today. Will add that later.



Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
@rocketsroger rocketsroger removed the 🕵️‍♀️ needs review PRs that need to be reviewed label Sep 3, 2019
@bors
Copy link

bors bot commented Sep 3, 2019

Build succeeded

@bors bors bot merged commit 9045e3b into mozilla-mobile:master Sep 3, 2019
@pocmo pocmo deleted the merge-day branch September 4, 2019 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants