This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Issue #6827: Move Thumbnails into its own browser component #6835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6827.
As we work through adding a disk cache for thumbnails in #2754, it is becoming clear we should move the thumbnails feature into its own browser component. This is the first step in doing that by copying over
ThumbnailsFeature.kt
andThumbnailsFeatureTest.kt
over toBrowserThumbnails
.We also switched the Sample Browser to use the new
BrowserThumbnails
component. I have categorized this component as under development since #2754 will make it more of a real feature.As the next step that I want to do is look into adding a deprecation warning for
ThumbnailsFeature
, but I didn't think it was necessary in this PR and could be made as a follow up.Pull Request checklist
After merge