This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Closes #9131: Add site permission indicators in the toolbar #9162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocmo
reviewed
Dec 8, 2020
components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/BrowserToolbar.kt
Outdated
Show resolved
Hide resolved
components/browser/toolbar/src/main/res/layout/mozac_browser_toolbar_displaytoolbar.xml
Outdated
Show resolved
Hide resolved
components/browser/state/src/main/java/mozilla/components/browser/state/state/ContentState.kt
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts when rebasing. Could you fix it @Amejia481? 🙏 |
Amejia481
force-pushed
the
issue-9131
branch
3 times, most recently
from
dc11b4e to
fb8a8b7
Compare
|
@pocmo I updated the pr! |
in the toolbar.
…ermissionsFeature
|
I added this separated commit 7dfcf44 for updating indicator when need and showing it on sample browsers |
3 tasks
pocmo
approved these changes
Dec 10, 2020
pocmo
added
🛬 needs landing
|
:) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to add an icon in the toolbar to make users aware of some site permissions that are allowed/denied on a site.
For the moment, we want to start with autoplay to mimic the same behaviour as we have in desktop see #9131 (comment), later we could add an site permission indicator when sites are granted location access (same as desktop).
This is an example of how the icon will work after we finish working on #9156, for now we want to introduce the api.
Fenix pr mozilla-mobile/fenix#16947
Pull Request checklist
After merge