Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Tab Tray: Screenshots are broken after delete+undo #11192

Closed
AndiAJ opened this issue Jun 3, 2020 · 6 comments
Closed

[Bug]Tab Tray: Screenshots are broken after delete+undo #11192

AndiAJ opened this issue Jun 3, 2020 · 6 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 3, 2020

Prerequisites

Have a couples of open tabs

Steps to reproduce

  1. Swipe delete a tab
  2. Undo the deletion
  3. Close a tab by using the 'x' (close button)
  4. Undo the deletion
  5. Tap the ⋮ button select "Close all tabs"
  6. Undo
  7. Check screen shots

Expected behavior

After each deletion undo, the screenshots should be properly displayed

Actual behavior

After each deletion undo, it looks like minimized versions screenshots are displayed

Device information

  • Android device:
    • Google Pixel 3a (Android 10)
    • Huawei Mate 20 Lite (Android 9)
    • OnePlus A3 (Android 6.0.1)
  • Fenix version: Nightly Build 200603 from 6/3

Notes

► Screenshot
rszUNITO-UNDERSCORE!screenshot!UNITO-UNDERSCORE!20200603-174407!

► Video
20200603-174150

Related #10921

┆Issue is synchronized with this Jira Task

@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist Feature:Tabs labels Jun 3, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 3, 2020
@ekager ekager removed the needs:triage Issue needs triage label Jun 3, 2020
@liuche
Copy link
Contributor

liuche commented Jun 3, 2020

@gabrielluong how do you want thumbnails issues to get tracked? Just in the board, or through a label, or something else?

@gabrielluong
Copy link
Member

@gabrielluong how do you want thumbnails issues to get tracked? Just in the board, or through a label, or something else?

Most of the thumbnail issues would be fixed in AC. So, I think for tracking purposes we can put it in the tabs tray board as a stopgap.

@jonalmeida
Copy link
Contributor

This was fixed as part of mozilla-mobile/android-components#7352.

@jonalmeida jonalmeida added the eng:qa:needed QA Needed label Jun 16, 2020
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Jun 18, 2020

Hi, verified as fixed on Nightly 200618 from 6/18 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video
20200618-140320

► Video
20200618-140658

@AndiAJ AndiAJ closed this as completed Jun 18, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 18, 2020
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Jun 30, 2020

Hi @jonalmeida , noticed that on Fenix 79.0.1-beta.1 from 6/30 the screenshots are replaced with the placeholder icons after delete + undo
Is this the expected behaviour? please advise

@jonalmeida
Copy link
Contributor

@AndiAJ yes, this is expected behaviour. We are deleting the thumbnails on the device.

We have a separate bug to figure out how to keep the thumbnail until after the undo toast is gone. 🙂

@data-sync-user data-sync-user changed the title [Bug]Tab Tray: Screenshots are broken after delete+undo FNX2-16386 ⁃ [Bug]Tab Tray: Screenshots are broken after delete+undo Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16386 ⁃ [Bug]Tab Tray: Screenshots are broken after delete+undo FNX3-14460 ⁃ [Bug]Tab Tray: Screenshots are broken after delete+undo Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14460 ⁃ [Bug]Tab Tray: Screenshots are broken after delete+undo FNX-12071 ⁃ [Bug]Tab Tray: Screenshots are broken after delete+undo Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12071 ⁃ [Bug]Tab Tray: Screenshots are broken after delete+undo FNX2-16386 ⁃ [Bug]Tab Tray: Screenshots are broken after delete+undo Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16386 ⁃ [Bug]Tab Tray: Screenshots are broken after delete+undo [Bug]Tab Tray: Screenshots are broken after delete+undo May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Development

No branches or pull requests

7 participants