Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] (regression) it's no longer possible to download anything #14052

Closed
cadeyrn opened this issue Aug 22, 2020 · 9 comments
Closed

[Bug] (regression) it's no longer possible to download anything #14052

cadeyrn opened this issue Aug 22, 2020 · 9 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download

Comments

@cadeyrn
Copy link
Contributor

cadeyrn commented Aug 22, 2020

Steps to reproduce

  1. Try to download something: apk file, image file, whatever

Expected behavior

It works.

Actual behavior

The download fails. It's a regression from the last AC update to 56.0.20200821184.

logcat output when trying to download something:

2020-08-22 10:33:48.772 7182-7313/org.mozilla.fenix.debug E/AbstractFetchDownloadService: verifyDownload for https://www.google.com/images/branding/searchlogo/1x/googlelogo_tablet_tier1_hp_color_183x64dp.png FAILED

Device information

  • Android device: OnePlus 7T Pro McLaren Edition / Oxygen OS 10.0.10 (Android 10)
  • Fenix version: master branch revision 88a2273

┆Issue is synchronized with this Jira Task

@cadeyrn cadeyrn added the 🐞 bug Crashes, Something isn't working, .. label Aug 22, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 22, 2020
@vesta0
Copy link
Collaborator

vesta0 commented Aug 23, 2020

Looks like a regression, let's add it to the sprint @kglazko

@miDeb
Copy link
Contributor

miDeb commented Aug 23, 2020

Actually it looks like the download succeeds, fenix just reports it as failed. I can find the downloaded file in the file manager.

@kglazko
Copy link
Contributor

kglazko commented Aug 23, 2020

@Amejia481 Did anything downloads-related land in that last AC update?

@Amejia481 Amejia481 added the eng:qa:needed QA Needed label Aug 24, 2020
@Amejia481 Amejia481 self-assigned this Aug 24, 2020
@Amejia481 Amejia481 removed the eng:qa:needed QA Needed label Aug 24, 2020
@leogama
Copy link

leogama commented Aug 24, 2020

Actually it looks like the download succeeds, fenix just reports it as failed. I can find the downloaded file in the file manager.

The file is in fact downloaded but, for images at least, it's not listed in my file manager under Downloads, Images, Recent files, etc. or even in the Gallery app. I had to navigate through the file system tree (Internal storage > Downloads) to find it.

@miDeb
Copy link
Contributor

miDeb commented Aug 24, 2020

The file is in fact downloaded but, for images at least, it's not listed in my file manager under Downloads, Images, Recent files, etc. or even in the Gallery app. I had to navigate through the file system tree (Internal storage > Downloads) to find it.

That's probably unrelated, see
#8754.

@Amejia481
Copy link
Contributor

Thanks for reporting the issue, indeed is a regression from mozilla-mobile/android-components#8152, sorry about that.

As @miDeb mentioned downloads are getting downloaded but the UI it's not showing the right status, this PR contains the fix mozilla-mobile/android-components#8197, but as it has a larger scope will take longer to review. I'm putting a separate pr for addressing the issue.

@Amejia481
Copy link
Contributor

Amejia481 commented Aug 24, 2020

This pr will address the issue mozilla-mobile/android-components#8203, sorry about the inconveniences.

@liuche
Copy link
Contributor

liuche commented Aug 25, 2020

This should be in the Nightly build on 8/26, so putting a QA flag for that.

@lobontiumira
Copy link

Hi all,
I was able to download different types of files: .avi, .mp3, .zip, .jpg, on the latest Nightly build from 8/26 with Samsung Galaxy Tab S6 (Android 9), and Sony Xperia Z5 Premium (Android 7.1.1).
I'll remove the label and close this as verified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download
Projects
None yet
Development

No branches or pull requests

8 participants