Audit toolbar searches.count telemetry between old and new toolbar implementation

[data-sync-user]

Purpose:

Review the code and analyze the glean debugger pings to ensure symmetry between old and new toolbar implementations.

Telemetry Labels:

search.counts: https://dictionary.telemetry.mozilla.org/apps/firefox_ios/metrics/search_counts

• suggestion e.g. "google-b-m.suggestion"
  • When I type in the toolbar, get a suggestion, and then tap one of the suggestion rows
• actionbar  e.g. "google-b-m.actionbar"
  • When I type in the toolbar a search query (not a whole website) and then tap the "Go" button on the keyboard
• quicksearch e.g. ""bing.quicksearch""
  • When the user taps one of the alternative search engines in the strip above the keyboard

SQL Queries for Reference:

• https://sql.telemetry.mozilla.org/queries/105420/source
• https://sql.telemetry.mozilla.org/queries/105420/source

┆Issue is synchronized with this Jira Spike

[data-sync-user]

➤ Isabella commented:

actionbarCode examination:There are two call points for Glean.Search.counts:

• Inside the TelemetryWrapper for case(.action, .tap, .recordSearch, _, let extras):

  • Callers:

    • SearchViewController didSelectEngine

      • Called when: TODO

    • SearchViewController tableView didSelectRow

      • Called when: TODO

• Inside BrowserViewController+URLBarDelegate.swift.

  • Callers:
    • submitSearchText()

Glean debugger examination:✅ Experiment 1: New Toolbar: actionbar (with on_tap_new_search and navigation_hint both true)
Fresh app install.

Test 1: Search a term and press go on the keyboard.

• 2025-02-07 16:55:52 baseline ping
  • "google-b-m.actionbar": 1

Test 2: In the same session, from the SERP page, tap the address bar and tap go on the keyboard again (repeating the search, no changes)

• 2025-02-07 16:57:38 baseline ping
  • "google-b-m.actionbar": 1

Test 3: Change default search engine to DDG, then repeat #2

• 2025-02-07 16:58:42 baseline
  • "ddg.actionbar": 1

Test 4: Kill and Restart app… (with glean deep link)

• 2025-02-07 16:59:30 metrics ping

  • "ddg.actionbar": 1”
  • "google-b-m.actionbar": 2

• Summarizes the earlier pings from baseline, as expected.

Test 5: Kill and restart the app once more again…

• Does not send baseline or metrics ping for search.counts

[ ? ] Experiment 2: Old Toolbar: actionbar
Fresh app install.

TODO