Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

boto list_tables calls assumed to return all results #1000

Closed
pjenvey opened this issue Sep 5, 2017 · 1 comment
Closed

boto list_tables calls assumed to return all results #1000

pjenvey opened this issue Sep 5, 2017 · 1 comment
Assignees
@pjenvey
Labels
bug Operational p1
Milestone
PUSHSVC-0: quality

Comments

@pjenvey
Copy link
Member

pjenvey commented Sep 5, 2017

boto2's layer1 list_tables (db.py, maybe health.py?) as well as boto3's list_tables (our lambda script in maintenance.py) return paginated results. We're incorrectly assuming we'll get back all tables in one shot.

Luckily this hasn't bitten us on staging/prod (yet) but it's hit me on our dev env.
@pjenvey pjenvey added this to the PUSHSVC-0: quality milestone Sep 5, 2017
@pjenvey pjenvey self-assigned this Sep 5, 2017
@bbangert bbangert added the ready label Sep 5, 2017
pjenvey added a commit that referenced this issue Sep 8, 2017
@pjenvey
fix: ensure we paginate through all table names
f9f0d0b 
Closes #1000
@pjenvey pjenvey mentioned this issue Sep 8, 2017
Merged
@pjenvey pjenvey added in progress and removed ready labels Sep 8, 2017
@pjenvey
Copy link
Member Author

pjenvey commented Sep 11, 2017

Reopening: forgot about the call in our lambda script

@pjenvey pjenvey reopened this Sep 11, 2017
pjenvey added a commit that referenced this issue Sep 12, 2017
@pjenvey
fix: ensure lambda script paginates through all table names
d692c7f 
Closes #1000
@pjenvey pjenvey mentioned this issue Sep 12, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
bug Operational p1
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

No branches or pull requests
3 participants
@pjenvey @jrconlin @bbangert