Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

boto3 refactoring #1142

Closed
pjenvey opened this issue Mar 2, 2018 · 3 comments
Closed

boto3 refactoring #1142

pjenvey opened this issue Mar 2, 2018 · 3 comments
Assignees
Labels
discussion Discuss and close/break-out into other issues p3

Comments

@pjenvey
Copy link
Member

pjenvey commented Mar 2, 2018

There's some easy code cleanup around boto3 we should make:

  • checking exception codes should have a helper function
  • and following that, we could be checking against static strings to avoid typos (maybe we can use an enum backport?)
  • creating ClientErrors for tests could probably use a helper function?
  • our db interface could probably be rethought a bit now but I'll leave that for an entirely different issue
@pjenvey pjenvey added this to the PUSHSVC-0: quality milestone Mar 2, 2018
@bbangert bbangert added p1 discussion Discuss and close/break-out into other issues ready and removed enhancement p2 labels Mar 22, 2018
@pjenvey
Copy link
Member Author

pjenvey commented May 31, 2018

According to: https://stackoverflow.com/questions/33068055/boto3-python-and-how-to-handle-errors boto3 "has begun to expose service exceptions on clients (though not on resources)".

Using these would be a good improvement for #1 and #2 above (and maybe 3) over the generic ClientError. Though I'm unsure about the "though not on resources" part. This feature seems to still be undocumented (JR had originally used some of these exceptions but they were removed with them being documented in the first place)

@pjenvey pjenvey added p2 and removed p1 labels May 31, 2018
@jrconlin jrconlin self-assigned this Jun 19, 2018
@jrconlin jrconlin added p3 and removed p2 labels Jun 19, 2018
@jrconlin
Copy link
Member

Setting as P3. This is a "nice to have" since we're moving to rust.

@bbangert
Copy link
Member

Obsolete per Rust move this year.

@bbangert bbangert removed the ready label Jan 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion Discuss and close/break-out into other issues p3
Projects
None yet
Development

No branches or pull requests

3 participants