Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Nonexisting message tables are still accessed, causing errors #461

Closed
bbangert opened this issue May 5, 2016 · 0 comments
Closed

Nonexisting message tables are still accessed, causing errors #461

bbangert opened this issue May 5, 2016 · 0 comments
Assignees
Labels

Comments

@bbangert
Copy link
Member

bbangert commented May 5, 2016

May 05 16:52:04 ip-172-31-39-23 python[11560]: File "/data/autopush/app/autopush/router/webpush.py", line 74, in preflight_check
May 05 16:52:04 ip-172-31-39-23 python[11560]: self.ap_settings.message_tables[month_table].all_channels,
May 05 16:52:04 ip-172-31-39-23 python[11560]: exceptions.KeyError: u'prod.autopush.message_2016_3' 

It appears no handling is done to ensure the user has a new enough month when delivering messages. Since message tables 'too old' should be considered users who will be invalidated on a new connect, this issue should be handled as a 410 since the endpoint will never be valid again.

@bbangert bbangert added this to the PUSHSVC-0: quality milestone May 5, 2016
jrconlin added a commit that referenced this issue May 5, 2016
Adds full checks for preflight failure conditions.

Closes #461
jrconlin added a commit that referenced this issue May 5, 2016
Add full checks for preflight failure conditions.

Closes #461
@jrconlin jrconlin self-assigned this May 5, 2016
@jrconlin jrconlin added in progress and removed ready labels May 5, 2016
jrconlin added a commit that referenced this issue May 5, 2016
Add full checks for preflight failure conditions.

Closes #461
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants