You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
AWS will raise a ValidationError if an expression condition binds an argument that isn't included. register_user has this issue, likely from a GCM related call in endpoint.py as we had the error raised on stage at exactly the same time as a GCM error.
To ensure we don't miss arg's like this again, in addition to verifying endpoint.py is always passing them, all db methods in db.py should raise an Exception if they use a bounded expression condition for a variable that isn't in the object being passed in.
The text was updated successfully, but these errors were encountered:
db.py register_user is wrapped with a try handler, but it only catches ConditonalCheckFailedException. This exception should propagate up. To mitigate the problem sentry notes with registration, we can have register_user return early if "router_type" or "connected_at" are not specified. This would preserve existing behavior.
AWS will raise a ValidationError if an expression condition binds an argument that isn't included. register_user has this issue, likely from a GCM related call in endpoint.py as we had the error raised on stage at exactly the same time as a GCM error.
To ensure we don't miss arg's like this again, in addition to verifying endpoint.py is always passing them, all db methods in db.py should raise an Exception if they use a bounded expression condition for a variable that isn't in the object being passed in.
The text was updated successfully, but these errors were encountered: