You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Some sentry reports lack context due to twisted Failures not including a traceback.
One cause is twisted.web.client's _WrapperException which wraps other exceptions (possibly even multiple exceptions) and commonly lack a tb. We should special case these: log their wrapped exceptions instead, which'll likely include a context.
We can special case the logger to forcefully include the current stack trace when coming across these. That might provide enough context to track down their cause so we can improve their handling.
The text was updated successfully, but these errors were encountered:
Er, before special casing _WrapperExceptions inside the logger itself, let's ensure they're all trapped/handled for all our twisted.web.client calls. So they never propagate down to the logger in the first place.
(The logger special casing might still be useful in case we forget to handle new ones in the future).
* prefer base classes ConnectError/ConnectionClosed/ResponseFailed,
covering ConnectionRefused/UserError, ConnectionLost/Done,
ResponseNeverReceived
* handle ResponseFailed (ResponseNeverReceived) in the routers as
a broken connection
* trap these in PushServerProtocol._notify_node
closes#613, #554
Some sentry reports lack context due to twisted Failures not including a traceback.
One cause is twisted.web.client's _WrapperException which wraps other exceptions (possibly even multiple exceptions) and commonly lack a tb. We should special case these: log their wrapped exceptions instead, which'll likely include a context.
e.g. ResponseNeverReceived is one:
https://sentry.prod.mozaws.net/operations/autopush-prod/issues/345377/
There's others without a tb for unknown reasons:
https://sentry.prod.mozaws.net/operations/autopush-prod/issues/345112/events/8063796/
We can special case the logger to forcefully include the current stack trace when coming across these. That might provide enough context to track down their cause so we can improve their handling.
The text was updated successfully, but these errors were encountered: