This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
APNs bridge needs to allow multiple key pairs #655
Milestone
Comments
Huh, interesting. APNs ties a cert pair to the APNs channel it uses to communicate out. I had presumed that each platform (dev/stage/prod) would have it's own cert pair that it would use, but there's little reason we couldn't have this sort of division as well. I'd be concerned that we hit a problem similar to the senderID one, where an APNs channel uses the wrong identifier (e.g. a "prod" version uses "stage" or some similar problem). |
Right, it's tricky because there's a matrix, and they don't move in lockstep: the server has dev, stage, and prod environments; the client has Nightly, Beta, and Release channels. |
jrconlin
added a commit
that referenced
this issue
Sep 14, 2016
This patch updates APNs handlers to accept platform based cert configurations. See `configs/autopush_shared.ini.sample`. In addition, this patch clarifies some argument references for routers (e.g. less than useful `result` is now slightly more descriptive `uaid_data`) Custom item names have been normalized to match gcm/fcm. Document errors cleaned up a bit as well. BREAKING CHANGE: the APNS configuration options have been altered, see `configs/autopush_shared.ini.sample` for new APNS configuration settings. Closes #655
jrconlin
added a commit
that referenced
this issue
Sep 15, 2016
This patch updates APNs handlers to accept platform based cert configurations. See `configs/autopush_shared.ini.sample`. In addition, this patch clarifies some argument references for routers (e.g. less than useful `result` is now slightly more descriptive `uaid_data`) Custom item names have been normalized to match gcm/fcm. Document errors cleaned up a bit as well. BREAKING CHANGE: the APNS configuration options have been altered, see `configs/autopush_shared.ini.sample` for new APNS configuration settings. Closes #655
jrconlin
added a commit
that referenced
this issue
Sep 15, 2016
This patch updates APNs handlers to accept platform based cert configurations. See `configs/autopush_shared.ini.sample`. In addition, this patch clarifies some argument references for routers (e.g. less than useful `result` is now slightly more descriptive `uaid_data`) Custom item names have been normalized to match gcm/fcm. Document errors cleaned up a bit as well. BREAKING CHANGE: the APNS configuration options have been altered, see `configs/autopush_shared.ini.sample` for new APNS configuration settings. Closes #655
jrconlin
added a commit
that referenced
this issue
Sep 15, 2016
This patch updates APNs handlers to accept platform based cert configurations. See `configs/autopush_shared.ini.sample`. In addition, this patch clarifies some argument references for routers (e.g. less than useful `result` is now slightly more descriptive `uaid_data`) Custom item names have been normalized to match gcm/fcm. Document errors cleaned up a bit as well. BREAKING CHANGE: the APNS configuration options have been altered, see `configs/autopush_shared.ini.sample` for new APNS configuration settings. Closes #655
jrconlin
added a commit
that referenced
this issue
Sep 15, 2016
This patch updates APNs handlers to accept platform based cert configurations. See `configs/autopush_shared.ini.sample`. In addition, this patch clarifies some argument references for routers (e.g. less than useful `result` is now slightly more descriptive `uaid_data`) Custom item names have been normalized to match gcm/fcm. Document errors cleaned up a bit as well. BREAKING CHANGE: the APNS configuration options have been altered, see `configs/autopush_shared.ini.sample` for new APNS configuration settings. Closes #655
jrconlin
added a commit
that referenced
this issue
Sep 16, 2016
This patch updates APNs handlers to accept platform based cert configurations. See `configs/autopush_shared.ini.sample`. In addition, this patch clarifies some argument references for routers (e.g. less than useful `result` is now slightly more descriptive `uaid_data`) Custom item names have been normalized to match gcm/fcm. Document errors cleaned up a bit as well. BREAKING CHANGE: the APNS configuration options have been altered, see `configs/autopush_shared.ini.sample` for new APNS configuration settings. Closes #655
jrconlin
added a commit
that referenced
this issue
Sep 16, 2016
This patch updates APNs handlers to accept platform based cert configurations. See `configs/autopush_shared.ini.sample`. In addition, this patch clarifies some argument references for routers (e.g. less than useful `result` is now slightly more descriptive `uaid_data`) Custom item names have been normalized to match gcm/fcm. Document errors cleaned up a bit as well. BREAKING CHANGE: the APNS configuration options have been altered, see `configs/autopush_shared.ini.sample` for new APNS configuration settings. Closes #655
jrconlin
added a commit
that referenced
this issue
Sep 16, 2016
This patch updates APNs handlers to accept platform based cert configurations. See `configs/autopush_shared.ini.sample`. In addition, this patch clarifies some argument references for routers (e.g. less than useful `result` is now slightly more descriptive `uaid_data`) Custom item names have been normalized to match gcm/fcm. Document errors cleaned up a bit as well. BREAKING CHANGE: the APNS configuration options have been altered, see `configs/autopush_shared.ini.sample` for new APNS configuration settings. Closes #655
jrconlin
added a commit
that referenced
this issue
Sep 17, 2016
This patch updates APNs handlers to accept platform based cert configurations. See `configs/autopush_shared.ini.sample`. In addition, this patch clarifies some argument references for routers (e.g. less than useful `result` is now slightly more descriptive `uaid_data`) Custom item names have been normalized to match gcm/fcm. Document errors cleaned up a bit as well. BREAKING CHANGE: the APNS configuration options have been altered, see `configs/autopush_shared.ini.sample` for new APNS configuration settings. Closes #655
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Our APNs bridge only allows one key pair to be specified, but we have a different pair for each release channel: "Fennec", "Firefox", and "FirefoxBeta". I think we'll want something similar to the GCM bridge, which allows us to specify multiple sender IDs.
We currently ignore the
{app_id}
for APNs, so we can use that to determine the right key pair (for example, the URL would bePOST /v1/apns/FirefoxBeta/registration
). We can store that app ID in the router record, change the bridge config to accept multiple pairs, and have the router create an APNs client for each pair.The text was updated successfully, but these errors were encountered: