This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Message metrics are inaccurate #958
Comments
bbangert
added a commit
that referenced
this issue
Jul 19, 2017
The metric increments were being called for registration API calls due to an error callback. They weren't called for success cases as well. Moving them to the lower callbacks with a new flag should help ensure they're incremented correctly. Closes #958
bbangert
added a commit
that referenced
this issue
Jul 19, 2017
The metric increments were being called for registration API calls due to an error callback. They weren't called for success cases as well. Moving them to the lower callbacks with a new flag should help ensure they're incremented correctly. Closes #958
bbangert
added a commit
that referenced
this issue
Jul 19, 2017
The metric increments were being called for registration API calls due to an error callback. They weren't called for success cases as well. Moving them to the lower callbacks with a new flag should help ensure they're incremented correctly. Also fixed message_data calls to use increment instead of a gauge and removed sending of base_tags in websocket.py to avoid too many metric values. Closes #958
bbangert
added a commit
that referenced
this issue
Jul 19, 2017
The metric increments were being called for registration API calls due to an error callback. They weren't called for success cases as well. Moving them to the lower callbacks with a new flag should help ensure they're incremented correctly. Also fixed message_data calls to use increment instead of a gauge and removed sending of base_tags in websocket.py to avoid too many metric values. Closes #958
bbangert
added a commit
that referenced
this issue
Jul 19, 2017
The metric increments were being called for registration API calls due to an error callback. They weren't called for success cases as well. Moving them to the lower callbacks with a new flag should help ensure they're incremented correctly. Also fixed message_data calls to use increment instead of a gauge and removed sending of base_tags in websocket.py to avoid too many metric values. Closes #958
bbangert
added a commit
that referenced
this issue
Jul 19, 2017
The metric increments were being called for registration API calls due to an error callback. They weren't called for success cases as well. Moving them to the lower callbacks with a new flag should help ensure they're incremented correctly. Also fixed message_data calls to use increment instead of a gauge and removed sending of base_tags in websocket.py to avoid too many metric values. Closes #958
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The new message metrics fail to record message success if exc.log_exception is False under _router_fail_err. Since _router_fail_err ends up calling _router_response, that should probably be responsible for adding the metric increments.
The text was updated successfully, but these errors were encountered: