This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: remove unused udp wake capability #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
==========================================
- Coverage 99.78% 99.78% -0.01%
==========================================
Files 57 57
Lines 9656 9593 -63
==========================================
- Hits 9635 9572 -63
Misses 21 21
Continue to review full report at Codecov.
|
jrconlin
suggested changes
Sep 5, 2017
jrconlin
previously requested changes
Sep 5, 2017
| @@ -177,17 +177,6 @@ def _add_external_router_args(parser): | |||
| "APNS settings", | |||
| type=str, default="", | |||
| env_var="APNS_CREDS") | |||
| # UDP | |||
There was a problem hiding this comment.
Move these to _obsolete_args to save oremj a headache
bbangert
force-pushed
the
feat/issue-886
branch
from
23f1446 to
a6d2779
Compare
bbangert
force-pushed
the
feat/issue-886
branch
from
a6d2779 to
efc0d25
Compare
pjenvey
approved these changes
Sep 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #886