This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: have webpush router handle ClientErrors #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was previously handling only the old boto2 JSONResponseError in those spots also kill the remaining boto2 bits Closes #1138
Codecov Report
@@ Coverage Diff @@
## master #1141 +/- ##
==========================================
- Coverage 99.76% 99.76% -0.01%
==========================================
Files 60 60
Lines 9966 9951 -15
==========================================
- Hits 9943 9928 -15
Misses 23 23
Continue to review full report at Codecov.
|
jrconlin
approved these changes
Mar 2, 2018
| elif failure.check(InternalServerError): # pragma nocover | ||
| elif (failure.check(ClientError) and | ||
| failure.value.response["Error"]["Code"] == | ||
| "InternalServerError"): # pragma nocover |
There was a problem hiding this comment.
This is becoming a reoccurring pattern. I wonder if we should create a function that just does this combined check?
There was a problem hiding this comment.
Totally, I almost created one in this diff but figured I'd keep these short/readable. Logged #1142
bbangert
approved these changes
Mar 2, 2018
| @@ -64,3 +64,7 @@ class LogCheckError(Exception): | |||
|
|
|||
| class InvalidConfig(Exception): | |||
| """Error in initialization of AutopushConfig""" | |||
|
|
|||
|
|
|||
| class ItemNotFound(Exception): | |||
There was a problem hiding this comment.
😞 cause boto3 no longer provides such a useful thing....
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was previously handling only the old boto2 JSONResponseError in
those spots
also kill the remaining boto2 bits
Closes #1138