This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
bug: Fix up FCM library to reject enpdoints with invalid FCM senderids #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #573 diff @@
====================================
Files 42 42
Lines 8770 8774 +4
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 8770 8774 +4
Misses 0 0
Partials 0 0
|
| @@ -50,6 +50,8 @@ def register(self, uaid, router_data, router_token=None, *kwargs): | |||
| if "token" not in router_data: | |||
| raise self._error("connect info missing FCM Instance 'token'", | |||
| status=401) | |||
| if not (router_token == router_data['token'] == self.senderID): | |||
There was a problem hiding this comment.
You may or may not want to copy the associated comment over from gcm.py, up to you
|
r+ |
|
r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #556
(picks up spare from #561)
@bbangert @pjenvey r?