This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: return 404 for invalid URL's for consistency #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbangert
force-pushed
the
bug/issue-578
branch
from
dc1af31 to
bd7ba21
Compare
Current coverage is 100% (diff: 100%)@@ master #608 diff @@
====================================
Files 44 44
Lines 8953 8951 -2
Methods 0 0
Messages 0 0
Branches 0 0
====================================
- Hits 8953 8951 -2
Misses 0 0
Partials 0 0
|
bbangert
force-pushed
the
bug/issue-578
branch
from
bd7ba21 to
8394a1f
Compare
|
r+ |
1 similar comment
|
r+ |
bbangert
force-pushed
the
bug/issue-578
branch
8 times, most recently
from
9ecd6b0 to
2e05e24
Compare
bbangert
force-pushed
the
bug/issue-578
branch
3 times, most recently
from
4dfe329 to
af5b33f
Compare
| @@ -71,12 +71,13 @@ def timing(self, name, duration, **kwargs): | |||
| class DatadogMetrics(object): | |||
| """DataDog Metric backend""" | |||
| def __init__(self, api_key, app_key, flush_interval=10, | |||
| namespace="autopush"): | |||
| namespace="autopush", hostname="localhost"): | |||
There was a problem hiding this comment.
hrm. tempted to say this should be None instead of "localhost". Settings sets it to a value, and that's pretty much the only init location.
That or we drop get_hostname() and treat the fact that it's been forced to None as an error.
URL's that are invalid should return a 404, just like any other invalid URL. Closes #578
bbangert
force-pushed
the
bug/issue-578
branch
from
af5b33f to
f4c47af
Compare
|
r++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL's that are invalid should return a 404, just like any other
invalid URL.
Closes #578