This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: move preflight logic into webpush validation #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preflight logic only applies to webpush, and is now included in the validation up-front to avoid a return trip immediately to the thread-pool. Closes #765
jrconlin
approved these changes
Jan 6, 2017
Current coverage is 100% (diff: 100%)@@ master #772 diff @@
====================================
Files 46 46
Lines 9258 9232 -26
Methods 0 0
Messages 0 0
Branches 0 0
====================================
- Hits 9258 9232 -26
Misses 0 0
Partials 0 0
|
pjenvey
reviewed
Jan 9, 2017
| # Propagate the looked up user data back out | ||
| d["user_data"] = result | ||
|
|
||
| def _validate_webpush(self, d, result): | ||
| settings = self.context["settings"] # type: AutopushSettings | ||
| log = self.context["log"] # type: Logger |
There was a problem hiding this comment.
this Logger is ThreadedValidate's. I'm not sure we should bother passing it around, it's not too useful of a Logger source. WebPushNotification could have its own
There was a problem hiding this comment.
Agreed, though it is a validate's log messages so that seems ok. We don't use the origin log name anyways.
pjenvey
approved these changes
Jan 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preflight logic only applies to webpush, and is now included in
the validation up-front to avoid a return trip immediately to the
thread-pool.
Closes #765