refactor: cleanup some deferred arg bookkeeping #859
Conversation
Codecov Report
@@ Coverage Diff @@
## master #859 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 49 50 +1
Lines 9544 9568 +24
=====================================
+ Hits 9544 9568 +24
Continue to review full report at Codecov.
|
autopush/db.py
Outdated
| @@ -70,6 +70,7 @@ | |||
|
|
|||
| # Typing | |||
| T = TypeVar('T') # noqa | |||
| ItemLike = Union[Item, Dict[str, Any]] | |||
|
|
|||
There was a problem hiding this comment.
Dict[str, Any] looks like a pretty common pattern. Didn't know if you wanted to do a similar alias trick for that.
| if not uaid: | ||
| uaid = uuid.uuid4() | ||
| d = defer.execute( | ||
| router.register, |
There was a problem hiding this comment.
We are inconsistent with how we're calling router.register (sometimes via named args, sometimes via ordered.) We had gone to named args prior because ordered had lead to some sleeper bugs. I would recommend we stay with that practice so that future coders don't hit the same problems.
prepping some cleanup before the actual #695 handler change