bug: APNS may close a socket prematurely, resulting in an AttributeError

[jrconlin]

closes #862

[codecov-io]

Codecov Report

Merging #863 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #863    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          50     50            
  Lines        9568   9811   +243     
======================================
+ Hits         9568   9811   +243

Impacted Files	Coverage Δ
autopush/router/apnsrouter.py	100% <100%> (ø)	⬆️
autopush/router/apns2.py	100% <100%> (ø)	⬆️
autopush/tests/test_router.py	100% <0%> (ø)	⬆️
autopush/tests/test_integration.py	100% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06f8a03...ed86e26. Read the comment docs.

[pjenvey]

Wanna just upgrade to the latest hyper with its fix instead? Not a whole lot of difference in 0.6.2 vs 0.7.0 and it gets ping support which we were interested in anyway

(it's about time to upgrade our dependencies anyway)

[jrconlin]

I'm fine doing both. Update hyper and leave the attribute trap in place.

[pjenvey]

don't wanna hold this up when the ios guys are hammering away but if we're including the AttributeError now, does it ever get removed (i.e. if we're not confident 0.7.0 fixes it, when would we ever be)?

[jrconlin]

pjenvey: I was tracking python-hyper/hyper#272, but I agree that python-hyper/hyper@4d92624 should resolve the root issue. We can remove the AttributeError check in the future.