Fix #1666, add a browser-send-event module that ensures that sendEven…

…t is defined even if ga-activation.js fails

server/src/browser-send-event.js

@@ -0,0 +1,13 @@
+/* This module exists because on some browsers we find that ga-analytics doesn't get loaded */
+
+if (typeof window != "undefined" && window.sendEvent) {
+  module.exports = window.sendEvent;
+} else {
+  module.exports = function () {
+    if (window.sendEvent) {
+      window.sendEvent.apply(null, arguments);
+    } else {
+      console.log.apply(console, ["missing sendEvent("].concat(Array.from(arguments).concat([")"])));
+    }
+  };
+}

server/src/clientglue.js

@@ -1,6 +1,6 @@
 /* jslint browser:true */
-/* globals sendEvent */
 
+const sendEvent = require("./browser-send-event.js");
 let ReactDOM = require("react-dom"),
   { FrameFactory } = require("./views/frame.js"),
   { setGitRevision, staticLink } = require("./linker"),

server/src/pages/leave-page-shot/controller.js

@@ -1,6 +1,6 @@
-/* globals sendEvent */
 // const page = require("./page").page;
 
+const sendEvent = require("../../browser-send-event.js");
 let helperReadyResolve;
 let helperReadyPromise = new Promise((resolve, reject) => {
   helperReadyResolve = resolve;

server/src/pages/leave-page-shot/view.js

@@ -1,4 +1,5 @@
-/* globals location, sendEvent */
+/* globals location */
+const sendEvent = require("../../browser-send-event.js");
 const reactruntime = require("../../reactruntime");
 const React = require("react");
 

server/src/pages/shotindex/controller.js

@@ -1,4 +1,4 @@
-/* globals sendEvent */
+const sendEvent = require("../../browser-send-event.js");
 const page = require("./page").page;
 const { AbstractShot } = require("../../../shared/shot");
 

server/src/pages/shotindex/view.js

@@ -1,4 +1,5 @@
-/* globals location, controller, sendEvent */
+/* globals location, controller */
+const sendEvent = require("../../browser-send-event.js");
 const reactruntime = require("../../reactruntime");
 const { Footer } = require("../../footer-view.js");
 const React = require("react");

server/src/views/profile.js

@@ -1,4 +1,4 @@
-/* globals sendEvent */
+//const sendEvent = require("../browser-send-event.js");
 const React = require("react");
 const ReactDOM = require("react-dom");
 const events = require("../events");