Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Styled 404 page? #1548

Closed
pdehaan opened this issue Sep 19, 2016 · 1 comment
Closed

Styled 404 page? #1548

pdehaan opened this issue Sep 19, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@pdehaan
Copy link
Collaborator

pdehaan commented Sep 19, 2016

Ideally nobody would ever see 404 pages, but as somebody who always struggles to find the latest XPI while we get this moved over to Test Pilot, I've probably seen it far too often.

Spoiler alert:

mozilla_firefox


Steps to reproduce:

$ http get http://pageshot.dev.mozaws.net/homepage/mozilla-pageshot.xpi -v

GET /homepage/mozilla-pageshot.xpi HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Connection: keep-alive
Host: pageshot.dev.mozaws.net
User-Agent: HTTPie/0.9.1

HTTP/1.1 404 Not Found
Connection: keep-alive
Content-Length: 9
Content-Security-Policy: default-src 'self'; img-src 'self' www.google-analytics.com pageshotcontent.dev.mozaws.net data:; script-src 'self' www.google-analytics.com 'nonce-ae993b24-eaf2-450d-aa93-596c3aeaa4f9'; style-src 'self' 'unsafe-inline' https://code.cdn.mozilla.net; connect-src 'self' www.google-analytics.com; font-src https://code.cdn.mozilla.net;
Content-Type: text/plain; charset=utf-8
Date: Mon, 19 Sep 2016 21:29:01 GMT
ETag: W/"9-ngdvWIX1zBakta643krf9Q"
Server: nginx/1.8.1
X-Frame-Options: DENY
X-Powered-By: Express

Not found
@ianb ianb added this to the Stretch milestone Sep 21, 2016
@ianb ianb added the needs:UX label Sep 23, 2016
@ianb ianb self-assigned this Oct 13, 2016
@ianb
Copy link
Contributor

ianb commented Oct 18, 2016

Added in 3ba6f26

Looks like this:

image

Leaving this ticket open to review the styling and message. Look in server/src/pages/not-found/view.js for the actual copy.

@fzzzy fzzzy closed this as completed in 3ba6f26 Oct 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants