Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

pageshot.net lacks caching for all static assets #1624

Closed
peterbe opened this issue Sep 29, 2016 · 5 comments
Closed

pageshot.net lacks caching for all static assets #1624

peterbe opened this issue Sep 29, 2016 · 5 comments
Assignees
Milestone

Comments

@peterbe
Copy link

peterbe commented Sep 29, 2016

All repeat views take the same amount of time as the first view
https://www.webpagetest.org/result/160929_M4_1BQB/

@ianb
Copy link
Contributor

ianb commented Sep 29, 2016

There's some notes about this in #1557 about this – I think it's not all the static assets, but a bunch of them

@peterbe
Copy link
Author

peterbe commented Sep 29, 2016

16 files that are missing it according to webpagetest.org.

@peterbe
Copy link
Author

peterbe commented Sep 29, 2016

Also, when the cache headers are fixed, moving them to a CDN would also be great.

@ckprice ckprice added this to the Stretch milestone Oct 5, 2016
@ianb ianb self-assigned this Oct 19, 2016
@ianb
Copy link
Contributor

ianb commented Oct 20, 2016

I've added #1801 and #1802 to decrease the number of static assets slightly.

All resources should now have caching. ga-activation.js is somewhat of a special case, it's still cached but private (and can't go on a CDN).

We have minimization now running on the bundles (where most page logic goes) which decreases their size by about 50%. The bundles are still averaging 500Kb, so we could probably look more closely at the dependencies to decrease that. build/dependency-cache/ has listings. It's almost entirely React, so we can look at React-specific bundle optimizations. Followup in #1803

Making more scripts async is in #1804

We also put some content inline into the script that we don't have to, we could serve up a page that isn't live, and hydrate it in a subsequent request. That is listed in #1805.

Closing this ticket in preference of those specific tickets.

@ianb
Copy link
Contributor

ianb commented Nov 1, 2016

The cache-control changes were released in the v1 release which went out on October 26th.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants