Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Setup continuous deployment #2521

Closed
ianb opened this issue Mar 29, 2017 · 4 comments
Closed

Setup continuous deployment #2521

ianb opened this issue Mar 29, 2017 · 4 comments
Assignees

Comments

@ianb
Copy link
Contributor

ianb commented Mar 29, 2017

@relud is setting up a separate dev instance for us, to replace pageshot.dev.mozaws.net.

To deploy to this we need to build a docker image and upload it to mozilla/screenshots on dockerhub. ./bin/release-version stage pretty much does this, and we can use that as the basis for a dev release. I believe CircleCI would be the appropriate place to do this. We would have to get permissions setup so it can connect to dockerhub, and so it has authentication to produce signed XPIs.

Right now we might be only building the webextension/ portion in make signed_xpi, which doesn't exactly match the bootstrap.js add-on we ship. We should consider what we want to do here.

@relud
Copy link
Member

relud commented Mar 29, 2017

2 notes: 1) for dev i can easily deploy mozilla/pageshot:latest or mozilla/screenshots:latest, 2) I can get you permissions to push the images and file prs to get them pushed

@ckprice ckprice added this to the Stretch milestone Mar 29, 2017
@relud
Copy link
Member

relud commented Mar 31, 2017

@ianb ianb modified the milestones: Screenshots in 54, Stretch May 2, 2017
@ianb ianb self-assigned this May 4, 2017
@ianb
Copy link
Contributor Author

ianb commented May 4, 2017

I'll be updating ./bin/release-version dev to do the right thing.

Environmental variables we need: AMO_USER and AMO_SECRET to sign the xpi. ~/.docker/config.json must be setup, or some form of docker login must be done.

CircleCI docker instructions: https://circleci.com/docs/1.0/docker/

I'm not sure how to store the AMO credentials. CircleCI discourages any such storage: https://circleci.com/docs/1.0/environment-variables/

The only idea I have for this is to make the add-on ID configurable at build time, and create an account that can build that, and then the risk of putting those secrets in CircleCI is less. Or we just build an unsigned add-on, which maybe is okay (or at least not terrible).

There's also a question about whether we ship the bootstrap add-on or the WebExtension add-on. I believe the bootstrap add-on will stop being installable, and the WebExtension will be OK for localization purposes.

@ianb
Copy link
Contributor Author

ianb commented May 5, 2017

Let's start without any add-on signing, and update the install page to give instructions on how to turn off the signing requirement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants