Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

The saved shots cannot be deleted from "My Shots" page (stage) #2730

Closed
SoftVision-CosminMuntean opened this issue Apr 24, 2017 · 5 comments
Closed
Assignees

Comments

@SoftVision-CosminMuntean
Copy link

SoftVision-CosminMuntean commented Apr 24, 2017

[Affected versions]:

  • Firefox 55.0a1 (Build ID:20170424030211)
  • Screenshots 6.4.4794

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • The "xpinstall.signatures.required" is set to "false" and latest Firefox Screenshots (6.4.4794) custom build is installed on a new clean profile.
  • Have at least one shot saved the created profile.

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites and open a new tab.
  2. Click the Firefox Screenshots button from browser toolbar.
  3. Hover a saved shot and click the "Delete" icon.
  4. Click the "OK" button from the displayed dialog.
  5. Observe the browser behavior.

[Expected result]:

  • The saved shot is successfully deleted and is no longer displayed on "My Shots" page.

[Actual result]:

  • A "Error deleting shot: 500 Internal Server Error" is displayed and the shot is not deleted.

[Notes]:

  • The shot can be successfully deleted from the saved shot preview page.
  • Here is a screen recording with the issue:
    delete saved shots
@ghost ghost added this to the Screenshots in 54 milestone Apr 24, 2017
@ianb ianb self-assigned this Apr 24, 2017
@dannycoates
Copy link
Contributor

oops. /shots needs a csrf token

@ianb ianb removed their assignment Apr 25, 2017
@dannycoates dannycoates self-assigned this Apr 25, 2017
@ianb ianb closed this as completed in 2c8eb39 Apr 25, 2017
@SoftVision-CosminMuntean
Copy link
Author

@dannycoates It seems that this issue is also reproducible on the Nightly try build with the latest Screenshots release, received from jared.
A "Error deleting shot: 500 Internal Server Error" is displayed if you try to delete a shot from "My Shots" page.

So, probably this fix wasn't deployed to production too?

@ianb
Copy link
Contributor

ianb commented Apr 28, 2017

The fix should be deployed to stage (as of last night), but not to production yet

@SoftVision-CosminMuntean
Copy link
Author

@ianb So the current version of Screenshots from production will be uplifted in Firefox?

@ianb
Copy link
Contributor

ianb commented Apr 28, 2017

This bug is purely on the server, and we aren't at the moment coordinating server and client releases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants