Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Fix #3372, run server unit tests with npm run test #3582

Merged
merged 2 commits into from
Oct 3, 2017

Conversation

ianb
Copy link
Contributor

@ianb ianb commented Oct 2, 2017

Note tests have broken when they weren't being run.

I'm not that clear on how the tests should act, so I'm not sure how to fix. Errors:

  1) l10n middleware getLanguage function (Accept-Language header parsing) should return ["en-US"] if Accept-Language header value is "en-CA":

      AssertionError: 'en-US' == 'en-CA'
      + expected - actual

      -en-US
      +en-CA
      
      at Context.it (test/server/unit/middleware/l10n-test.js:24:14)

  2) l10n middleware getLanguage function (Accept-Language header parsing) should return ["en-US"] if Accept-Language header value is "en":

      AssertionError: 'en-US' == 'en'
      + expected - actual

      -en-US
      +en
      
      at Context.it (test/server/unit/middleware/l10n-test.js:30:14)

ianb and others added 2 commits October 2, 2017 16:44
Note tests have broken when they weren't being run
@jaredhirsch jaredhirsch force-pushed the test-server-unit-tests branch from 7a2b491 to 4e67057 Compare October 3, 2017 23:10
@jaredhirsch jaredhirsch merged commit 3079086 into master Oct 3, 2017
@jaredhirsch jaredhirsch deleted the test-server-unit-tests branch October 3, 2017 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants