This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fix #3674, put 50% of people into control #3723
Merged
+53
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This separates out people who are excluded from a test, from those who are in the control for the test. 50% of people always go to control, and 50% go into some experiment branch. People who aren't in either go into the 'exclude' category.
jaredhirsch
approved these changes
Nov 6, 2017
| @@ -39,7 +49,8 @@ let allTests = { | |||
| version: 1, | |||
| exclude: ["highlightButtonOnInstall", "autoOpenSharePanel"], | |||
| options: [ | |||
| // Note no one will end up in control in this example: | |||
| // Note no one will end up in exclude in this example (but 50% will still | |||
| // be control): | |||
There was a problem hiding this comment.
@ianb If I'm understanding this correctly, since 10% of the population is in the autoOpenSharePanel test, and another 10% is in the highlightButtonOnInstall test, and people in those tests are excluded from this myShotsDisplay test, then, 50% of the remaining total 80% of users will be in the control group in this test, while the other half will be 9:1 split between the 'intropopup' and 'blink' tests. Does that seem correct?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates out people who are excluded from a test, from those who are in the control for the test. 50% of people always go to control, and 50% go into some experiment branch. People who aren't in either go into the 'exclude' category.