Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Audit screenshots.firefox.com CSP #3979

Closed
ghost opened this issue Jan 17, 2018 · 3 comments
Closed

Audit screenshots.firefox.com CSP #3979

ghost opened this issue Jan 17, 2018 · 3 comments
Labels
security Security issue: can be an active issue, or related to security hygene

Comments

@ghost
Copy link

ghost commented Jan 17, 2018

see comment further down

@ghost ghost added the security Security issue: can be an active issue, or related to security hygene label Jan 17, 2018
@ghost ghost self-assigned this Jan 24, 2018
@ghost
Copy link
Author

ghost commented Jan 29, 2018

Ok, I think I copied from the wrong site. This is screenshots.firefox.com:

 Content-Security-Policy: 
   default-src 'self'; 
   img-src 'self' stable.dev.lcip.org www.google-analytics.com screenshotscdn.firefox.com screenshotscdn.firefoxusercontent.com screenshots.firefoxusercontent.com data:; 
   script-src 'self' screenshotscdn.firefox.com www.google-analytics.com 'nonce-74c01282-fc60-493c-b255-3bc4d36bebb7'; 
   style-src 'self' screenshotscdn.firefox.com 'unsafe-inline' https://code.cdn.mozilla.net; 
   connect-src 'self' screenshotscdn.firefox.com www.google-analytics.com sentry.prod.mozaws.net; 
   font-src https://code.cdn.mozilla.net; 
   frame-ancestors 'none'; 
   object-src 'none';

So, the questions I see from this are:

  • Do we need stable.dev.lcip.org for images?
  • Do we need unsafe-inline for styles?

@chenba
Copy link
Collaborator

chenba commented Apr 27, 2018

  • stable.dev.lcip.org (or whatever's configured for FxA) is necessary because of the FxA user profile image.
  • There are some inline style. And for something that's per shot, like the favicon (set as a background-image), setting it dynamically inline make sense. It might make more sense to use <img>. So we just need to go through all the inline style and review them if we want to remove them.

@ghost
Copy link
Author

ghost commented Apr 30, 2018

Thanks Barry!

@ghost ghost closed this as completed Apr 30, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
security Security issue: can be an active issue, or related to security hygene
Projects
None yet
Development

No branches or pull requests

2 participants