This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Wait until save button is visible in a test 🤷♂️ #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredhirsch
reviewed
Feb 15, 2018
| @@ -224,6 +224,10 @@ describe("Test Screenshots", function() { | |||
| return driver.wait( | |||
| until.elementLocated(By.css(".preview-button-save")) | |||
| ); | |||
| }).then((saveButton) => { | |||
| return driver.wait( | |||
| until.elementIsVisible(saveButton) | |||
There was a problem hiding this comment.
If this isn't enough to eliminate intermittent failures, there's an element.isEnabled() method which polls for a visible form element to not have the disabled attribute on it. Some discussion in this SO answer. We'd have to start toggling the disabled attribute when frames are loaded, but it could be worth it.
chenba
force-pushed
the
4108-ci-selenium-fail
branch
from
7fc0dba to
9bda135
Compare
chenba
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4108, maybe?
Since the issue is intermittent and occurs only on CircleCI, it's difficult to say with some degree of certainty that this fixes #4108 (even if the tests have passed in five builds for #4114 on CircleCI).