Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Switch en-US FTL file to new syntax #4115

Merged
merged 1 commit into from
Feb 16, 2018
Merged

Switch en-US FTL file to new syntax #4115

merged 1 commit into from
Feb 16, 2018

Conversation

flodolo
Copy link
Collaborator

@flodolo flodolo commented Feb 15, 2018

  • # for comment sigil
  • no more sections,## for section comments
  • equal sign on empty value

CC @Pike

// Global phrases shared across pages, prefixed with 'g'
[[ global ]]
### Localization for Server-side strings of Firefox Screenshots
### Please don't localize Firefox, Firefox Screenshots, or Screenshots
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add Terms for these?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would invalidate a ton of existing translations. So, I wouldn't be happy about it.

We might think about introducing terms and using them in new strings for the future.

Copy link
Member

@jaredhirsch jaredhirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the patch 🍻

@jaredhirsch jaredhirsch merged commit 983a0fb into mozilla-services:master Feb 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants