Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Define the browser support matrix #4527

Closed
stasm opened this issue Jun 5, 2018 · 3 comments
Closed

Define the browser support matrix #4527

stasm opened this issue Jun 5, 2018 · 3 comments

Comments

@stasm
Copy link
Contributor

stasm commented Jun 5, 2018

What is the intended browser support matrix for https://screenshots.firefox.com?

I'm asking because in projectfluent/fluent.js#133 we're considering dropping the support for old versions of Chrome and Firefox as well as the support for IE11. Fluent is used the localize the Screenshots website. Dropping the support would mean that the fluent/compat builds would contain async functions and function* generators, which cause syntax errors in browsers which don't support them.

@stasm
Copy link
Contributor Author

stasm commented Jun 5, 2018

FYI, here's the list of browser versions we're currently considering supporting in Fluent's compat builds:

Firefox >= 52,
FirefoxAndroid >= 52,
Chrome >= 55,
ChromeAndroid >= 55,
Edge >= 15,
Safari >= 10.1,
iOS >= 10.1

Would that work for Screenshots?

@ianb
Copy link
Contributor

ianb commented Jun 5, 2018

We do server-side rendering and localization, so if client-side localization is broken it won't keep people from viewing pages. So dropping IE11 support won't keep IE11 users from viewing screenshots.

We don't have a specific browser support matrix, but the one you propose will work fine for us.

@ianb ianb closed this as completed Jun 5, 2018
@stasm
Copy link
Contributor Author

stasm commented Jun 6, 2018

Thanks, @ianb. Sorry if I'll make you repeat the same thing again, but I'd like to make sure Fluent doesn't cause trouble for you. If we drop IE11 support, the fluent/compat module will cause syntax errors in the entire shot-bundle.js. All JS will be broken because of this. However, the website is served pre-rendered and pre-localized, and the minimal functionality of viewing screenshots will continue to work even in those older browsers. Did I get that right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants