This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Minor fixes for dev and stage xpi signing #4734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid logging the token in the curl command * Document the additional dev-root pref in the install-test-local page
jaredhirsch
force-pushed
the
xpi-signing-quiet
branch
from
4497b13 to
0c61ba5
Compare
jaredhirsch
changed the title
g-k
reviewed
Aug 2, 2018
| @@ -38,6 +38,7 @@ <h1>Dev Firefox Screenshots</h1> | |||
| <li><strong><code>xpinstall.signatures.required</code></strong> to <code>false</code></li> | |||
| <li><strong><code>extensions.legacy.enabled</code></strong> to <code>true</code></li> | |||
| <li><strong><code>extensions.install.requireBuiltInCerts</code></strong> to <code>false</code></li> | |||
| <li><strong><code>xpinstall.signatures.dev-root</code></strong> to <code>true</code> | |||
There was a problem hiding this comment.
@6a68 FWIW This dev-root will need to be added as a new boolean property, but settings the others shouldn't be necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@g-k r?