This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fixes #4738 - Remove subtitle link favicon #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@6a68 Attaching PR that removes the code that displays subtitle link favicon. Will file a follow up bug to restore it when upstream bug returning image instead of url is fixed |
jaredhirsch
suggested changes
Aug 3, 2018
| @@ -400,12 +400,6 @@ class Body extends React.Component { | |||
| renderGetFirefox = renderExtensionNotification = false; | |||
| } | |||
|
|
|||
| let favicon = null; | |||
| if (shot.favicon) { | |||
There was a problem hiding this comment.
@punamdahiya Hmm, on second thought, it might be better to keep showing the favicon for the vast majority of shots, which have a regular favicon URL, and just change this line to:
if (shot.favicon && shot.favicon.startsWith('https'))
jaredhirsch
approved these changes
Aug 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.