You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
In #4617 (specifically a5935e1) we added npm audit and removed nsp (per #4704). But npm audit is run like npm audit || true, as we have failures we can't reasonably fix. We should reenable it as something that can make the CI tests fail.
I personally would propose we use npm audit --json | ./bin/some_ignoring_script where write some_ignoring_script to parse the JSON and ignore some packages we don't care to fix. E.g., jpm has a dependency (open) with a "critical error" that I feel confident we can ignore (because it is only used in our build system, never with untrusted input).
The text was updated successfully, but these errors were encountered:
In #4617 (specifically a5935e1) we added npm audit and removed nsp (per #4704). But npm audit is run like
npm audit || true
, as we have failures we can't reasonably fix. We should reenable it as something that can make the CI tests fail.I personally would propose we use
npm audit --json | ./bin/some_ignoring_script
where writesome_ignoring_script
to parse the JSON and ignore some packages we don't care to fix. E.g.,jpm
has a dependency (open
) with a "critical error" that I feel confident we can ignore (because it is only used in our build system, never with untrusted input).The text was updated successfully, but these errors were encountered: