Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Add alt tag to inline images used on home, shot and myshots #4976

Closed
punamdahiya opened this issue Oct 1, 2018 · 3 comments
Closed

Add alt tag to inline images used on home, shot and myshots #4976

punamdahiya opened this issue Oct 1, 2018 · 3 comments
Labels
a11y good first issue
Milestone
Sprint 27 (66-1)

Comments

@punamdahiya
Copy link
Contributor

See #4940 (comment)
@punamdahiya punamdahiya mentioned this issue Oct 1, 2018
Merged
@chenba
Copy link
Collaborator

chenba commented Oct 1, 2018

All non-decorative images should have alt text.

@johngruen johngruen added this to the Sprint 24 (65-1) milestone Oct 2, 2018
@ianb ianb modified the milestones: Sprint 24 (65-1), Sprint 25 (65-2) 🎃 Oct 29, 2018
@johngruen johngruen modified the milestones: Sprint 25 (65-2) 🎃, Sprint 26 (65-3) Nov 12, 2018
@punamdahiya
Copy link
Contributor Author

Tested with Voice Over Screen Reader on Safari, title attribute of button/link on my shots page - signin, share, download and delete button get read after identifying tag as button or link.

Only exception is favorite button (my shots) which is read as group and should be updated to button instead of div

@punamdahiya
Copy link
Contributor Author

Closing this as duplicate of #4667

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a11y good first issue
Projects
None yet
Milestone
Sprint 27 (66-1)
Development

No branches or pull requests
5 participants
@ianb @chenba @punamdahiya @johngruen @marniepw