This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fixes #5146 - Copy string on myshots shows blank #5153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodolo
reviewed
Nov 8, 2018
server/src/share-buttons.js
Outdated
| @@ -155,10 +155,10 @@ class ShareButtonPanel extends React.Component { | |||
| value={ this.props.shot.viewUrl } | |||
| onClick={ this.onClickInputField.bind(this) } | |||
| onChange={ function() {} /* react gives a warning otherwise */ } /> | |||
| <Localized id={ this.state.copy === "copy" ? "shotPageCopy" : "shotPageCopied" }> | |||
| <Localized id={ this.state.copy === "copy" ? "shotPageCopyText" : "shotPageCopied" }> | |||
There was a problem hiding this comment.
I'm confused. What was "shotPageCopy" before this PR?
There was a problem hiding this comment.
@flodolo that was for exact same text "Copy" but got removed in a PR that landed for new copy button on shots.
Bringing it back with new id as we still need it on my shots page or can we still use the same id in this case?
flodolo
reviewed
Nov 8, 2018
locales/en-US/server.ftl
Outdated
| @@ -100,6 +100,7 @@ shotPageShareButton = | |||
| .title = Share | |||
| shotPageCopyButton = | |||
| .title = Copy image to clipboard | |||
| shotPageCopyText = Copy | |||
There was a problem hiding this comment.
English is unclear (noun or verb?), I'd prefer a different ID to avoid confusion, e.g. shotPageCopyActionLabel (since shotPageCopyButton is already in use)
There was a problem hiding this comment.
It's a verb, will update with suggested ID
punamdahiya
force-pushed
the
5146-copy-string
branch
from
efe493f to
29298c2
Compare
flodolo
approved these changes
Nov 8, 2018
jaredhirsch
approved these changes
Nov 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.